On Thu, 26 May 2022 at 01:50, Alvin Šipraga <ALSI@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 25, 2022 at 06:53:16PM -0300, Fabio Estevam wrote:
> > ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[]
> > are only used inside adv7511_cec.c.
> >
> > Move their definitions to this file to avoid the following build
> > warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]
> > drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Fixes: ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")
> > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> > ---
>
> Thank you for fixing this.
>
> Reviewed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
>
>
> > drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------
> > drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > index 9e3bb8a8ee40..a031a0cd1f18 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> > @@ -226,18 +226,6 @@
> > #define ADV7511_REG_CEC_CLK_DIV 0x4e
> > #define ADV7511_REG_CEC_SOFT_RESET 0x50
> >
> > -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> > - ADV7511_REG_CEC_RX1_FRAME_HDR,
> > - ADV7511_REG_CEC_RX2_FRAME_HDR,
> > - ADV7511_REG_CEC_RX3_FRAME_HDR,
> > -};
> > -
> > -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> > - ADV7511_REG_CEC_RX1_FRAME_LEN,
> > - ADV7511_REG_CEC_RX2_FRAME_LEN,
> > - ADV7511_REG_CEC_RX3_FRAME_LEN,
> > -};
> > -
> > #define ADV7533_REG_CEC_OFFSET 0x70
> >
> > enum adv7511_input_clock {
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > index 399f625a50c8..0b266f28f150 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
> > @@ -15,6 +15,18 @@
> >
> > #include "adv7511.h"
> >
> > +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR[] = {
> > + ADV7511_REG_CEC_RX1_FRAME_HDR,
> > + ADV7511_REG_CEC_RX2_FRAME_HDR,
> > + ADV7511_REG_CEC_RX3_FRAME_HDR,
> > +};
> > +
> > +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN[] = {
> > + ADV7511_REG_CEC_RX1_FRAME_LEN,
> > + ADV7511_REG_CEC_RX2_FRAME_LEN,
> > + ADV7511_REG_CEC_RX3_FRAME_LEN,
> > +};
> > +
> > #define ADV7511_INT1_CEC_MASK \
> > (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \
> > ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
> > --
> > 2.25.1
> >
Applied to drm-misc-next
