This is already static, in our local branch, from this commit: commit 6852e61a0917a2 Author: Evan Quan <evan.quan@xxxxxxx> Date: Thu May 19 17:28:12 2022 +0800 drm/amdgpu: suppress some compile warnings Suppress two compile warnings about "no previous prototype". Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: Evan Quan <evan.quan@xxxxxxx> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> Regards, Luben On 2022-05-24 04:11, Jiapeng Chong wrote: > This symbol is not used outside of amdgpu_discovery.c, so marks it static. > > Fixes the following w1 warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no > previous prototype for ‘amdgpu_discovery_get_mall_info’ > [-Wmissing-prototypes]. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > index 881570dced41..16cdfb30b013 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > @@ -1361,7 +1361,7 @@ union mall_info { > struct mall_info_v1_0 v1; > }; > > -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev) > +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev) > { > struct binary_header *bhdr; > union mall_info *mall_info; Regards, -- Luben