Hi, On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@xxxxxxxxxx> wrote: > > If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m, > bulding fails: > > drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe': > panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to > `drm_panel_dp_aux_backlight' > make: *** [vmlinux] Error 1 > > Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and > CONFIG_DRM_DISPLAY_HELPER to fix this error. > > Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel") > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: gaochao <gaochao49@xxxxxxxxxx> I think the author / Signed-off-by are supposed to be real names. Is "gaochao" your legal name? > --- > drivers/gpu/drm/panel/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) Other than the Signed-off-by / Author issue: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>