On Fri, May 20, 2022 at 12:20:40AM -0700, Saurabh Sengar wrote: > There were two different approaches getting used in this driver to > allocate vram: > 1. VRAM allocation from PCI region for Gen1 > 2. VRAM alloaction from MMIO region for Gen2 > First approach limilts the vram to PCI BAR size, which is 64 MB in most > legacy systems. This limits the maximum resolution to be restricted to > 64 MB size, and with recent conclusion on fbdev issue its concluded to have > similar allocation strategy for both Gen1 and Gen2. This patch unifies > the Gen1 and Gen2 vram allocation strategy. > > Signed-off-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx> > --- > FBdev patch Ref : > https://lore.kernel.org/lkml/20220428143746.sya775ro5zi3kgm3@liuwe-devbox-debian-v2/T/ > [...] > -static int hyperv_setup_gen2(struct hyperv_drm_device *hv, > - struct hv_device *hdev) > +static int hyperv_setup_gen(struct hyperv_drm_device *hv, > + struct hv_device *hdev) There is no need to have "_gen" suffix anymore. I don't know much about the rest so cannot really make any meaningful comment here. Thanks, Wei.