> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, May 17, 2022 8:04 PM > To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; > Andrew Jeffery <andrew@xxxxxxxx>; Felipe Balbi <balbi@xxxxxxxxxx>; Sumit > Semwal <sumit.semwal@xxxxxxxxxx>; Christian König > <christian.koenig@xxxxxxx>; Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>; > Li Yang <leoyang.li@xxxxxxx> > Cc: linux-aspeed@xxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; > dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-sig@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 3/3] dt-bindings: usb: add documentation for aspeed > udc > > On 17/05/2022 10:25, Neal Liu wrote: > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/aspeed-clock.h> > > + usb: usb@1e6a2000 { > > + compatible = "aspeed,ast2600-udc"; > > Sorry for not noticing it earlier - slipped through the cracks. You use here > unusual indentation (not matching the rest of the example - above is 4 spaces, > here is 7 or 8). > > Just keep 4 spaces for DTS example. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Got it. I'll revise it for next patch. Thanks for your review. > Best regards, > Krzysztof