On Wed, May 11, 2022 at 7:28 AM Joel Selvaraj <jo@xxxxxxxxxxx> wrote:
> Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode
> panel, which can be found on some Xiaomi Poco F1 phones. The panel's
> backlight is managed through QCOM WLED driver.
>
> Signed-off-by: Joel Selvaraj <jo@xxxxxxxxxxx>
I see my review comments on v1 arrived after v2.
Nevertheless, please address my review comments on v1.
> +struct ebbg_ft8719 {
> + struct drm_panel panel;
> + struct mipi_dsi_device *dsi;
> +
> + struct regulator_bulk_data supplies[ARRAY_SIZE(regulator_names)];
> +
> + struct gpio_desc *reset_gpio;
> + bool prepared;
For example that means to drop this prepared member.
Yours,
Linus Walleij
