On 13.05.22 15:25, Zack Rusin wrote: >> On May 13, 2022, at 3:43 AM, Thorsten Leemhuis >> <regressions@xxxxxxxxxxxxx <mailto:regressions@xxxxxxxxxxxxx>> wrote: >> >> CCing airlied >> >> On 09.05.22 14:02, Javier Martinez Canillas wrote: >>> On 5/9/22 13:55, Hans de Goede wrote: >>> [snip] >>>>>> >>>>>> Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") >>>>>> BugLink: >>>>>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D2072556&data=05%7C01%7Czackr%40vmware.com%7Ca34647a1351748917ad608da34b459a0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637880246471436744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LSQP%2Bqnf4p51QsF%2B7ZkvKlB5gSx0%2FgRUsgcIPChR33g%3D&reserved=0 >>>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D2072556&data=05%7C01%7Czackr%40vmware.com%7Ca34647a1351748917ad608da34b459a0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637880246471436744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LSQP%2Bqnf4p51QsF%2B7ZkvKlB5gSx0%2FgRUsgcIPChR33g%3D&reserved=0> >>>>>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx >>>>>> <mailto:hdegoede@xxxxxxxxxx>> >>>>>> --- >>>>> >>>>> Zack fixed this already: >>>>> >>>>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Fcommit%2F%3Fid%3D5405d25b9e8e6&data=05%7C01%7Czackr%40vmware.com%7Ca34647a1351748917ad608da34b459a0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637880246471436744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IMtLj94VBo3Bv8oCGmbatBmT%2F2%2B9xkIptnlPTPuHMHc%3D&reserved=0 >>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Fcommit%2F%3Fid%3D5405d25b9e8e6&data=05%7C01%7Czackr%40vmware.com%7Ca34647a1351748917ad608da34b459a0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637880246471436744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IMtLj94VBo3Bv8oCGmbatBmT%2F2%2B9xkIptnlPTPuHMHc%3D&reserved=0> >>>> >>>> I see, but it seems that this was never pushed to drm-misc-fixes, >>>> so this is still broken in 5.18-rc# >>> >>> Indeed. Agreed that should be cherry-picked in -fixes as well. >> >> Looks to me like nobody did that and this regression fix is missing in > > No, it has been done. It’s after rc6 so the patch is in > drm-misc-next-fixes you can see it at: > https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/vmwgfx?h=drm-misc-next-fixes&id=5405d25b9e8e6e0d3bdb04833d528a9bb35fe7ce > <https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/vmwgfx?h=drm-misc-next-fixes&id=5405d25b9e8e6e0d3bdb04833d528a9bb35fe7ce> Sorry, I try, but keeping track of subsystem specific rules and branches is hard -- and Javier actually asked for "drm-misc-fixes". That being said: I'd like to question the approach here, as the docs for handling regression clearly explain that this regression fix should be applied this cycle: https://www.kernel.org/doc/html/latest/process/handling-regressions.html [background: the fixes tag in the change mentions an older commit, but it sees the problem surfaced post-5.17 cycle, as Hand pointed out at the start of this thread where he linked here: https://bugzilla.redhat.com/show_bug.cgi?id=2072556 ] Sure, there are fixes that are dangerous and maybe should wait for the next cycle, but from what I see this one doesn't look like one of those. And if we don't fix this now many more people will run into this. Dave, Daniel, could you please consider picking this up? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
