Hello Thomas, On 5/11/22 14:05, Thomas Zimmermann wrote: [snip] >> >> Other subsystems ask you to do the opposite, to split the definition and >> usage in separate patches. But I'm fine with merging those if you prefer. > > Usually, I have no strong opinion on this. But in the case of this > specific patchset, I have the feeling that I'm missing some important > point because call and implementation are separate. See my other > replies for that. Putting them next to each other will hopefully help. > Sorry for the inconvenience. > No worries at all. Happy to do that change if the patches are easy to understand. It took me some time as well to wrap my head around all the race conditions and needed locking. Same for patch 3/7, but I'm convinced that dropping the lock is the correct thing to do than calling to drivers' .remove callbacks with a lock held. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
