On Fri, 06 May 2022 17:39:53 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > On Fri, 06 May 2022 15:05:32 +0100, Andre Przywara wrote: > > The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans > > out a framebuffer and hands the pixels over to a digital signal encoder. > > It supports multiple layers, scaling and rotation. > > > > Convert the existing DT binding to DT schema. > > > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > > --- > > .../bindings/display/arm,malidp.txt | 68 ---------- > > .../bindings/display/arm,malidp.yaml | 116 ++++++++++++++++++ > > 2 files changed, 116 insertions(+), 68 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt > > create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > display@f080000: 'arm,malidp-arqos-value' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dtb > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb Ah, good point, I missed that directory when testing. I came up with the following change on top: ============================== diff --git a/Documentation/devicetree/bindings/display/arm,malidp.yaml b/Documentation/devicetree/bindings/display/arm,malidp.yaml index ea7b7100548bf..bc0d3f3ab2b75 100644 --- a/Documentation/devicetree/bindings/display/arm,malidp.yaml +++ b/Documentation/devicetree/bindings/display/arm,malidp.yaml @@ -76,6 +76,14 @@ properties: description: integer describing the ARQoS levels of DP500's QoS signaling + arm,malidp-arqos-value: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Quality-of-Service value for the display engine FIFOs, to write + into the RQOS register of the DP500. + See the ARM Mali-DP500 TRM for details on the encoding. + If omitted, the RQOS register will not be changed. + port: $ref: /schemas/graph.yaml#/properties/port unevaluatedProperties: false ============================== Cheers, Andre