On Fri, 06 May 2022, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Fri, May 06, 2022 at 01:10:24PM +0300, Jani Nikula wrote: >> +int drm_edid_to_sad(const struct edid *edid, struct cea_sad **sads) >> +{ >> + struct drm_edid drm_edid = { >> + .edid = edid, >> + .size = edid_size(edid), >> + }; >> + >> + return _drm_edid_to_sad(&drm_edid, sads); > > No need to check for NULL edid in these wrappers? Yeah, we do, and CI concurs. *facepalm*. BR, Jani. > >> +} >> EXPORT_SYMBOL(drm_edid_to_sad); >> >> /** >> -- >> 2.30.2 -- Jani Nikula, Intel Open Source Graphics Center