Hi,
On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote:
> Hi,
> On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote:
> > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
> > works with a Mixel MIPI DPHY + LVDS PHY combo to support either
> > a MIPI DSI display or a LVDS display. So, this patch calls
> > phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
> > explicitly.
> >
> > Cc: Guido Günther <agx@xxxxxxxxxxx>
> > Cc: Robert Chiras <robert.chiras@xxxxxxx>
> > Cc: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> > Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Cc: Jonas Karlman <jonas@xxxxxxxxx>
> > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: NXP Linux Team <linux-imx@xxxxxxx>
> > Signed-off-by: Liu Ying <victor.liu@xxxxxxx>
Hope this patch won't fall through the cracks.
Can someone please apply it to drm-misc-next? Robert?
Thanks,
Liu Ying
> > ---
> > v7->v8:
> > * Resend with Andrzej's and Jernej's mail addressed updated.
> >
> > v6->v7:
> > * No change.
> >
> > v5->v6:
> > * Rebase the series upon v5.17-rc1.
> > * Set PHY mode in ->mode_set() instead of ->pre_enable() in the
> > nwl-dsi
> > bridge driver due to the rebase.
> > * Drop Guido's R-b tag due to the rebase.
> >
> > v4->v5:
> > * No change.
> >
> > v3->v4:
> > * No change.
> >
> > v2->v3:
> > * No change.
> >
> > v1->v2:
> > * Add Guido's R-b tag.
> >
> > drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c
> > b/drivers/gpu/drm/bridge/nwl-dsi.c
> > index d5945501a5ee..85bab7372af1 100644
> > --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> > @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi
> > *dsi)
> > return ret;
> > }
> >
> > + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
> > + if (ret < 0) {
> > + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n",
> > ret);
> > + goto uninit_phy;
> > + }
> > +
> > ret = phy_configure(dsi->phy, phy_cfg);
> > if (ret < 0) {
> > DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n",
> > ret);
>
> I can't currently test this but it still looks good so
>
> Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
>
> Cheers,
> -- Guido
>
> > --
> > 2.25.1
> >
