On 4/29/22 09:27, Thomas Zimmermann wrote: > Hi > > Am 29.04.22 um 09:21 schrieb Javier Martinez Canillas: >> Hello Thomas, >> >> On 4/26/22 14:03, Thomas Zimmermann wrote: >>> Rename various instances of pagelist to pagereflist. The list now >>> stores pageref structures, so the new name is more appropriate. >>> >>> In their write-back helpers, several fbdev drivers refer to the >>> pageref list in struct fb_deferred_io instead of using the one >>> supplied as argument to the function. Convert them over to the >>> supplied one. It's the same instance, so no change of behavior >>> occurs. >>> >>> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> >>> Suggested-by: Sam Ravnborg <sam@xxxxxxxxxxxx> >> >> I thougt the convention was to have Suggested-by before your S-o-B. > > I always thought that the convention was that the authors S-o-B goes > first. But 'git log' indeed indicates otherwise. I will change this > before merging the patch. > The way I understand it, is that besides other things it indicates a chronological order of events. So the S-o-B will go first, followed by any Reviewed-by, Acked-by, etc gathered. But if someone suggests a change to you, that means the suggestion happened before you wrote the patch and is expected to go first. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
