28.04.2022 15:33, Daniel Vetter пишет: > On Sun, Apr 24, 2022 at 10:04:22PM +0300, Dmitry Osipenko wrote: >> VirtIO-GPU driver was the only user of drm_gem_shmem_get_pages() >> and it now uses drm_gem_shmem_get_pages_sgt(). Make the get_pages() >> private to drm_gem_shmem_helper. >> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +-- >> include/drm/drm_gem_shmem_helper.h | 1 - >> 2 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c >> index 25e9bc2803ee..7ec5f8002f68 100644 >> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c >> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c >> @@ -490,7 +490,7 @@ static int drm_gem_shmem_get_pages_locked(struct drm_gem_shmem_object *shmem) >> * Returns: >> * 0 on success or a negative error code on failure. >> */ > > We also delete the kerneldoc for functions not exported (kerneldoc is > geared towards driver writes). If there's anything critical the comment > explains about the internals, you can keep that as a normal C style > comment without the /** but generally there's no need for these anymore. Noted for v6.
