Hi Am 28.04.22 um 11:11 schrieb Javier Martinez Canillas:
On 4/28/22 10:42, Thomas Zimmermann wrote:Hi[snip]drivers/gpu/drm/display/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig index f84f1b0cd23f..1b6e6af37546 100644 --- a/drivers/gpu/drm/display/Kconfig +++ b/drivers/gpu/drm/display/Kconfig @@ -31,7 +31,8 @@ config DRM_DISPLAY_HDMI_HELPERconfig DRM_DP_AUX_CHARDEVbool "DRM DP AUX Interface" - depends on DRM + depends on DRM && DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPERMy rationale was that since DRM_DISPLAY_DP_HELPER is not a user-visible symbol but DRM_DP_{AUX_CHARDEV,CEC} are, the latter should be able to be enabled by the user without relying on other drivers to select the required symbols (I would argue that even should select DP_HELPER but that can't be done or otherwise the helper couldn't be built as module). In other words, either DRM_DP_{AUX_CHARDEV,CEC} can be user selectable as a standalone symbol or can't and will only be visible if other driver selects their required symbols. In which case, why not just do this non-user visible and just make the drivers using their helpers to select it directly? That is one of the options I proposed before. So I believe this is the less intrusive change that will preserve the current behaviour as much as possible.
Makes sense. Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>Maybe wait a bit before landing, so that the actual maintainers have a chance to comment.
Best regards Thomas
I don't have a strong opinion though and if you prefer I can change to be a depends instead.
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
