On 4/28/22 10:04, Thomas Zimmermann wrote: [snip] >> >> Right. So giving even more thought to this, now I think that we should just include >> drm_dp_aux_dev.o, drm_dp_cec.o (and probably drm_dp_aux_bus.o?) unconditionally to >> drm_display_helper-$(CONFIG_DRM_DISPLAY_DP_HELPER). >> >> After all, these are not big objects and drm_display_helper can now be built as module. >> >> I don't see that much value to have separate user-configurable config options... >> > > I don't know the side effects of this. We're exporting another device > file after all. > > For know I'd make them depend on DRM_DISPLAY_DP_HELPER. If someone > complains we can revert and fix the linker error by adding stub > functions for the missing symbols. > Ok, I'll just add the depends on then to fix the linking errors and then either adding the stubs when disabled or just making it part of the DP_HELPER can be done as a follow-up. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
