On Mon, Apr 25, 2022 at 4:24 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote: > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@xxxxxxxxxx> wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@xxxxxxxxxx> wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@xxxxxxxxxxxxxxxx> wrote: > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx> > > > > --- > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > index 376da01243a3..71df977e8f53 100644 > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > if (!pdata->mipi_host_node) { > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > return -ENODEV; > > > > } > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > + bus_type = 0; > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > if (ep0) { > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > } > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > - pdata->is_dpi = 0; > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > + pdata->is_dpi = 1; > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> > > > > Acked-by: Robert Foss <robert.foss@xxxxxxxxxx> > > Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > mainline (next-20220422). Forgot to mention, this device uses the already supported but broken (by previous DPI patch) DSI interface.