Quoting Arnd Bergmann (2022-04-19 09:37:58) > diff --git a/include/linux/clk/pxa.h b/include/linux/clk/pxa.h > new file mode 100644 > index 000000000000..e5516c608c99 > --- /dev/null > +++ b/include/linux/clk/pxa.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifdef CONFIG_PXA3xx > +extern unsigned pxa3xx_get_clk_frequency_khz(int); What is the spacing about here? > +extern void pxa3xx_clk_update_accr(u32 disable, u32 enable, u32 xclkcfg, u32 mask); > +#else > +#define pxa3xx_get_clk_frequency_khz(x) (0) > +#define pxa3xx_clk_update_accr(disable, enable, xclkcfg, mask) do { } while (0) Why not static inline with types?