Hi Karol, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.18-rc3 next-20220420] [cannot apply to drm-intel/for-linux-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-c002 (https://download.01.org/0day-ci/archive/20220420/202204201854.2R6j6WjR-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/50a17180127b7d2527ee9a8f5c9e8207e158afb6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 git checkout 50a17180127b7d2527ee9a8f5c9e8207e158afb6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/i915_vma.c: In function 'release_references': >> drivers/gpu/drm/i915/i915_vma.c:1654:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 1654 | struct intel_gt *gt = vma->vm->gt; | ^~~~~~ cc1: all warnings being treated as errors vim +1654 drivers/gpu/drm/i915/i915_vma.c 1640 1641 static void release_references(struct i915_vma *vma, bool vm_ddestroy) 1642 { 1643 struct drm_i915_gem_object *obj = vma->obj; 1644 1645 GEM_BUG_ON(i915_vma_is_active(vma)); 1646 1647 spin_lock(&obj->vma.lock); 1648 list_del(&vma->obj_link); 1649 if (!RB_EMPTY_NODE(&vma->obj_node)) 1650 rb_erase(&vma->obj_node, &obj->vma.tree); 1651 1652 spin_unlock(&obj->vma.lock); 1653 > 1654 struct intel_gt *gt = vma->vm->gt; 1655 1656 spin_lock_irq(>->closed_lock); 1657 __i915_vma_remove_closed(vma); 1658 spin_unlock_irq(>->closed_lock); 1659 1660 if (vm_ddestroy) 1661 i915_vm_resv_put(vma->vm); 1662 1663 i915_active_fini(&vma->active); 1664 GEM_WARN_ON(vma->resource); 1665 i915_vma_free(vma); 1666 } 1667 -- 0-DAY CI Kernel Test Service https://01.org/lkp
