Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx> Will push to the appropriate branch in a moment On Mon, 2022-04-18 at 11:28 -0400, Tom Rix wrote: > Smatch reports this issue > gf108.c:147:1: warning: symbol 'gf108_gr_fwif' > was not declared. Should it be static? > > gf108_gr_fwif is only used in gf108.c. Single > file variables should not be global so change > gf108_gr_fwif's storage-class specifier to static. > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > --- > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c > b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c > index 030640bb3dca..ab3760e804b8 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c > @@ -143,7 +143,7 @@ gf108_gr = { > } > }; > > -const struct gf100_gr_fwif > +static const struct gf100_gr_fwif > gf108_gr_fwif[] = { > { -1, gf100_gr_load, &gf108_gr }, > { -1, gf100_gr_nofw, &gf108_gr }, -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat