On Wed, 13 Apr 2022 18:23:54 +0200, Javier Martinez Canillas wrote: > The current compatible strings for SSD130x I2C controllers contain both an > "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver > and also that are for devices that can be accessed over an I2C bus. > > But a DT is supposed to describe the hardware and not Linux implementation > details. So let's deprecate those compatible strings and add new ones that > only contain the vendor and device name, without any of these suffixes. > > These will just describe the device and can be matched by both I2C and SPI > DRM drivers. The required properties should still be enforced for old ones. > > While being there, just drop the "sinowealth,sh1106-i2c" compatible string > since that was never present in a released Linux version. > > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > Acked-by: Mark Brown <broonie@xxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > > (no changes since v3) > > Changes in v3: > - Drop the "sinowealth,sh1106-i2c", wasn't in a released version (Chen-Yu Tsai) > - Continue enforcing required properties for deprecated strings (Maxime Ripard) > > Changes in v2: > - Drop the -i2c suffixes from the compatible strings too (Geert Uytterhoeven) > > .../bindings/display/solomon,ssd1307fb.yaml | 44 +++++++++++++------ > 1 file changed, 31 insertions(+), 13 deletions(-) > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>