On 4/13/22 19:58, Thomas Zimmermann wrote: > Hi [snip] >>> >>> /* Populate everything else. */ >>> of_platform_default_populate(NULL, NULL, NULL); >> >> I'm pretty sure it's just this call that's the problem for PPC though >> none of the above existed when adding this caused a regression. Can we >> remove the ifdef and just make this call conditional on >> !IS_ENABLED(CONFIG_PPC). > > Together with the changes in of_platform_populate_framebuffers(), the > code is more or less an "if-else" depending on PPC. I'll drop > of_platform_populate_framebuffers() from the patch and make a separate > implementation of of_platform_default_populate_init for PPC. Seems like > the easiest solution to me. > That sounds reasonable to me as well. Feel free to retain my R-B tag when posting v2. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
