On 4/13/22 19:02, Andy Shevchenko wrote: > On Wed, Apr 13, 2022 at 06:23:57PM +0200, Javier Martinez Canillas wrote: >> These are declared in the ssd130x-i2c transport driver but the information >> is not I2C specific, and could be used by other SSD130x transport drivers. >> >> Move them to the ssd130x core driver and just set the OF device entries to >> an ID that could be used to lookup the correct device info from an array. >> >> While being there, also move the SSD130X_DATA and SSD130X_COMMAND control >> bytes. Since even though they are used by the I2C interface, they could >> also be useful for other transport protocols such as SPI. > > Thanks! > > ... > >> @@ -139,6 +106,8 @@ static struct i2c_driver ssd130x_i2c_driver = { >> }; >> module_i2c_driver(ssd130x_i2c_driver); >> >> + > > Seems stray change. Dunno if maintainers can fix this when applying. > Ups, indeed. I can fix it when applying. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat