Hello Andy, On 4/13/22 12:46, Andy Shevchenko wrote: > On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote: >> These are declared in the ssd130x-i2c transport driver but the information >> is not I2C specific, and could be used by other SSD130x transport drivers. >> >> Move them to the ssd130x core driver and just set the OF device entries to >> an ID that could be used to lookup the correct device info from an array. >> >> While being there, also move the SSD130X_DATA and SSD130X_COMMAND control >> bytes. Since even though they are used by the I2C interface, they could >> also be useful for other transport protocols such as SPI. > > ... > >> +EXPORT_SYMBOL_GPL(ssd130x_variants); > > What I meant is to use EXPORT_SYMBOL_NS_GPL() here. It might require a separate > patch to move other exports to that namespace first. > Oh, I wasn't aware of the namespace aware variant of these. Thanks for pointing it out! I'll change and use that one instead for v4. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
