On Mon, 2022-04-11 at 10:31 +0800, xinlei.lee@xxxxxxxxxxxx wrote: > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > > In the dsi_enable function, mtk_dsi_rxtx_control is to > pull up the MIPI signal operation. Before dsi_disable, > MIPI should also be pulled down by writing a register > instead of disabling dsi. > > If disable dsi without pulling the mipi signal low, the value of > the register will still maintain the setting of the mipi signal being > pulled high. > After resume, even if the mipi signal is not pulled high, it will > still > be in the high state. > > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 9ad6f08c8bfe..e35343357f90 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -676,6 +676,8 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi) > mtk_dsi_reset_engine(dsi); > mtk_dsi_lane0_ulp_mode_enter(dsi); > mtk_dsi_clk_ulp_mode_enter(dsi); > + /* set the lane number as 0 to pull down mipi */ > + writel(0, dsi->regs + DSI_TXRX_CTRL); > > mtk_dsi_disable(dsi); > Reviewed-by: Rex-BC Chen <rex-bc.chen@xxxxxxxxxxxx>
