On Mon, Apr 11, 2022 at 04:13:34PM +0200, Christoph Hellwig wrote: > Match the style of the main i915 Makefile in the gvt-specfic one and > remove the GVT_DIR and GVT_SOURCE variables. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > drivers/gpu/drm/i915/gvt/Makefile | 29 +++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile > index 4d70f4689479c..f2f6ea02714ec 100644 > +++ b/drivers/gpu/drm/i915/gvt/Makefile > @@ -1,8 +1,25 @@ > # SPDX-License-Identifier: GPL-2.0 > -GVT_DIR := gvt > -GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ > - interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \ > - execlist.o scheduler.o sched_policy.o mmio_context.o cmd_parser.o debugfs.o \ > - fb_decoder.o dmabuf.o page_track.o > > -i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) > +i915-y += \ > + gvt/gvt.o \ > + gvt/aperture_gm.o \ > + gvt/handlers.o \ > + gvt/vgpu.o \ > + gvt/trace_points.o \ > + gvt/firmware.o \ > + gvt/interrupt.o \ > + gvt/gtt.o \ > + gvt/cfg_space.o \ > + gvt/opregion.o \ > + gvt/mmio.o \ > + gvt/display.o \ > + gvt/edid.o \ > + gvt/execlist.o \ > + gvt/scheduler.o \ > + gvt/sched_policy.o \ > + gvt/mmio_context.o \ > + gvt/cmd_parser.o \ > + gvt/debugfs.o \ > + gvt/fb_decoder.o \ > + gvt/dmabuf.o \ > + gvt/page_track.o Up to you but I usually sort these lists Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason
