On Wed, 2022-04-06 at 16:44 +0200, Krzysztof Kozlowski wrote: > On 06/04/2022 11:46, Rex-BC Chen wrote: > > The driver data of MT8183 and MT8173 are different. > > The value of has_gamma for MT8173 is true while the value of MT8183 > > is > > false. Therefore, the compatible of disp_aal for MT8183 is not > > suitable > > for the compatible for MT8173. > > Just because one feature is not supported, it does not mean they are > incompatible, which you claim in the patch below. Are you sure they > are > really incompatible and MT8173 fallback cannot be used? > > > Best regards, > Krzysztof Hello Krzysztof, Thanks for your review. The difference of disp_aal for each MediaTek SoCs is "has_gamma". And we only control this variable for different MediaTek SoCs. The value of has_gamma for MT8173 is true. The value of has_gamma for MT8183 is false. (Moreover, the driver data is null for MT8183)