On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote: > On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote: > > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@xxxxxxxxxxxx wrote: > > > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > > > > > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC. > > > > > > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > > | 1 > > > + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi > > > .yam > > > l > > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi > > > .yam > > > l > > > index dd2896a40ff0..a73044c50b5f 100644 > > > --- > > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi > > > .yam > > > l > > > +++ > > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi > > > .yam > > > l > > > @@ -22,6 +22,7 @@ properties: > > > - mediatek,mt7623-dpi > > > - mediatek,mt8173-dpi > > > - mediatek,mt8183-dpi > > > + - mediatek,mt8186-dpi > > > - mediatek,mt8192-dpi > > > > > > reg: > > > > Hello Xinlei, > > > > From the dts we use, the dpi node needs other properties for > > MT8186. > > Please send another patch and add these properties to binding. > > > > assigned-clocks = <&topckgen CLK_TOP_DPI>; > > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>; > > Those are always allowed on any node with 'clocks', so no need to > add > them here. > > Rob Hi Rob: Thank you for your review. I understand your suggestion, and the next version will be sent soon. Best Regards! xinlei
