On Wed, 2022-04-06 at 15:13 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@xxxxxxxxxxxx wrote:
> > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..6fac146cf1fb 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
>
> Hello Xinlei,
>
> Could you move 8186 between 8183 and 8192?
>
> > static int mtk_dpi_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -945,6 +953,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
> > + },
>
> ditto
>
> BRs,
> Rex
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>
>
Hi Rex:
Thanks for your review.
I will put it between 8183 & 8192 in the next version.
In addition, I will add two properties assigned-clocks & assigned-
clock-parents to dtbing.
Best Regards!
xinlei
