On Tue, 5 Apr 2022 at 16:41, Vinod Polimera <quic_vpolimer@xxxxxxxxxxx> wrote:
>
> Check if the dpu format is supported or not using dpu_find_format.
>
> Co-developed-by: Kalyan Thota <quic_kalyant@xxxxxxxxxxx>
> Signed-off-by: Kalyan Thota <quic_kalyant@xxxxxxxxxxx>
> Signed-off-by: Vinod Polimera <quic_vpolimer@xxxxxxxxxxx>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 22 ++++++++++++++++++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 10 +++-------
> 2 files changed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h
> index 418f5ae..84b8b32 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h
> @@ -21,6 +21,28 @@ const struct dpu_format *dpu_get_dpu_format_ext(
> #define dpu_get_dpu_format(f) dpu_get_dpu_format_ext(f, 0)
>
> /**
> + * dpu_find_format - validate if the pixel format is supported
> + * @format: dpu format
> + * @supported_formats: supported formats by dpu HW
> + * @num_formatss: total number of formats
> + *
> + * Return: false if not valid format, true on success
> + */
> +static inline bool dpu_find_format(u32 format, const u32 *supported_formats,
> + size_t num_formats)
> +{
> + int i;
> +
> + for (i = 0; i < num_formats; i++) {
> + /* check for valid formats supported */
> + if (format == supported_formats[i])
> + return true;
> + }
> +
> + return false;
> +}
> +
> +/**
> * dpu_get_msm_format - get an dpu_format by its msm_format base
> * callback function registers with the msm_kms layer
> * @kms: kms driver
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 6565682..3216cda 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -1411,13 +1411,9 @@ static bool dpu_plane_format_mod_supported(struct drm_plane *plane,
> if (modifier == DRM_FORMAT_MOD_LINEAR)
> return true;
>
> - if (modifier == DRM_FORMAT_MOD_QCOM_COMPRESSED) {
> - int i;
> - for (i = 0; i < ARRAY_SIZE(qcom_compressed_supported_formats); i++) {
> - if (format == qcom_compressed_supported_formats[i])
> - return true;
> - }
> - }
> + if (modifier == DRM_FORMAT_MOD_QCOM_COMPRESSED)
> + return dpu_find_format(format, qcom_compressed_supported_formats,
> + ARRAY_SIZE(qcom_compressed_supported_formats));
>
> return false;
> }
> --
> 2.7.4
>
--
With best wishes
Dmitry
