On Fri, Apr 1, 2022 at 5:32 PM Javier Martinez Canillas <javier@xxxxxxxxxxxx> wrote: > > Hello Chen-Yu, > > Thanks a lot for your patch. > > On Wed, Mar 30, 2022 at 9:09 PM Chen-Yu Tsai <wens@xxxxxxxxxx> wrote: > > > > From: Chen-Yu Tsai <wens@xxxxxxxx> > > > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > > compatible with the SSD1306. It supports a slightly wider display, > > at 132 instead of 128 pixels. The basic commands are the same, but > > the SH1106 doesn't support the horizontal or vertical address modes. > > > > Add a compatible string for it. > > > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > > --- > > Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > > index 9baafd0c42dd..1ac016a2d847 100644 > > --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > > @@ -13,6 +13,7 @@ maintainers: > > properties: > > compatible: > > enum: > > + - sinowealth,sh1106-i2c > > I like that you didn't include a "fb" suffix for this, the existing > ones are cargo culting from the previous fbdev driver to make existing > DTBs compatible with the DRM driver. > > I've been thinking if I should post a patch to compatible strings > without the "fb" and mark the current ones as deprecated... > > Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> I also thought about dropping the "-i2c" suffix, but then thought there might be a case where someone wanted to search the device tree specifically for an I2C connected node using said compatible string. What do you think? ChenYu
