dear Alex Deucher
I just mean where unneeded semicolon comes from when I add fixes info. As your remind, I have got it, thank you.
-------- 原始邮件 --------
发件人：Alex Deucher <alexdeucher@xxxxxxxxx>
时间：2022年4月1日 21:26
收件人：Paul Menzel <pmenzel@xxxxxxxxxxxxx>
抄送：白浩文 <baihaowen@xxxxxxxxx>,David Airlie <airlied@xxxxxxxx>,"Pan, Xinhui" <Xinhui.Pan@xxxxxxx>,LKML <linux-kernel@xxxxxxxxxxxxxxx>,Maling list - DRI developers <dri-devel@xxxxxxxxxxxxxxxxxxxxx>,amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>,Daniel Vetter <daniel@xxxxxxxx>,Alex Deucher <alexander.deucher@xxxxxxx>,Christian König <christian.koenig@xxxxxxx>
主题：Re: [PATCH] drm/amdgpu/vcn: remove Unneeded semicolon
On Fri, Apr 1, 2022 at 1:54 AM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
>
> Dear Haowen,
>
>
> Thank you for your patch.
>
> Am 31.03.22 um 07:56 schrieb Haowen Bai:
>
> In the commit message summary, please use:
>
> Remove unneeded semicolon
>
> > report by coccicheck:
> > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1951:2-3: Unneeded semicolon
> >
> > fixed c543dcb ("drm/amdgpu/vcn: Add VCN ras error query support")
>
> Please use
>
> Fixes: …
>
> and a commit hash length of 12 characters. (`scripts/checkpatch.pl …`
> should tell you about this.)
I don't know that you need to add a fixes tag unless the patch is an
actual bug fix. Coding style or spelling fixes are not really
critical for getting into stable trees.
Alex
>
>
> Kind regards,
>
> Paul
>
>
> > Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > index 3e1de8c..17d44be 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > @@ -1948,7 +1948,7 @@ static uint32_t vcn_v2_6_query_poison_by_instance(struct amdgpu_device *adev,
> > break;
> > default:
> > break;
> > - };
> > + }
> >
> > if (poison_stat)
> > dev_info(adev->dev, "Poison detected in VCN%d, sub_block%d\n",
>
> Dear Haowen,
>
>
> Thank you for your patch.
>
> Am 31.03.22 um 07:56 schrieb Haowen Bai:
>
> In the commit message summary, please use:
>
> Remove unneeded semicolon
>
> > report by coccicheck:
> > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1951:2-3: Unneeded semicolon
> >
> > fixed c543dcb ("drm/amdgpu/vcn: Add VCN ras error query support")
>
> Please use
>
> Fixes: …
>
> and a commit hash length of 12 characters. (`scripts/checkpatch.pl …`
> should tell you about this.)
I don't know that you need to add a fixes tag unless the patch is an
actual bug fix. Coding style or spelling fixes are not really
critical for getting into stable trees.
Alex
>
>
> Kind regards,
>
> Paul
>
>
> > Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > index 3e1de8c..17d44be 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> > @@ -1948,7 +1948,7 @@ static uint32_t vcn_v2_6_query_poison_by_instance(struct amdgpu_device *adev,
> > break;
> > default:
> > break;
> > - };
> > + }
> >
> > if (poison_stat)
> > dev_info(adev->dev, "Poison detected in VCN%d, sub_block%d\n",
