> On Wed, Mar 30, 2022 at 2:03 PM Xiaomeng Tong <xiam0nd.tong@xxxxxxxxx> wrote: > > > > Instead of exiting the loop as expected when an entry is found, the > > list_for_each_entry() continues until the traversal is complete. It > > could result in multiple 'is_*' flags being set with true mistakely. > > > > To fix this, when found the entry, add a break after the switch > > statement. > > > > Fixes: 89c78134cc54d (" gma500: Add Poulsbo support") > > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@xxxxxxxxx> > > This patch doesn't apply for me and needs to be rebased on top of > drm-misc-next or drm-tip. > > On Poulsbo there should only be one encoder per crtc so this is only a > theoretical issue. But it is good practice to exit the loop early if > we can so the patch still makes sense. > > Also, please use the correct subject prefix: drm/gma500: instead of > just gma500:. I will resend another patch as you suggested, thank you. -- Xiaomeng Tong