On Wed, Mar 30, 2022 at 9:09 PM Chen-Yu Tsai <wens@xxxxxxxxxx> wrote: > > From: Chen-Yu Tsai <wens@xxxxxxxx> > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > compatible with the SSD1306. It supports a slightly wider display, > at 132 instead of 128 pixels. The basic commands are the same, but > the SH1106 doesn't support the horizontal or vertical address modes. > > Add support for this display driver. The default values for some of > the hardware settings are taken from the datasheet. > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > --- > drivers/gpu/drm/solomon/ssd130x-i2c.c | 11 +++++++++++ Thanks a lot for this patch. It's very nice to see that another variant of the OLED controller is being supported! I wonder if we should also list SH1106 in the drivers/gpu/drm/solomon/Kconfig file so people can find it ? ah, one comment I forgot in 3/4 but that also applies to this patch, I believe the convention in DRM is for the subject line to be "drm/ssd130x:" instead of "drm: ssd130x:" Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> Best regards, Javier
