On Thu, 31 Mar 2022, "Wang, Zhi A" <zhi.a.wang@xxxxxxxxx> wrote: > Hi Jani and Joonas: > > Are you OK with these patches? I noticed I need to change the license > of the new file. Will do that when check-in if you are OK with these. Use SPDX license header instead of the full text? I don't know much about the actual contents, I'll leave that part to others. Seems that you are dropping const in a number of places where I thought you could perhaps retain it. Also in drivers/gpu/drm/i915/intel_gvt_mmio_table.c: #include "gvt.h" looks bad. It should be "gvt/gvt.h". I realize you can do that because gvt/Makefile has: ccflags-y += -I $(srctree)/$(src) -I $(srctree)/$(src)/$(GVT_DIR)/ which I think should be removed. I sent patches fixing this to give you an idea. No need to queue them first, I can rebase them later. But please make sure this builds without the ccflags. BR, Jani. > > Thanks, > Zhi. > > On 3/28/22 6:50 AM, Christoph Hellwig wrote: >> On Fri, Mar 25, 2022 at 01:52:49PM -0400, Zhi Wang wrote: >>> >>> v7: >>> >>> - Keep the marcos of device generation in GVT-g. (Christoph, Jani) >> >> The changelog go under the "---" line (also for the other patches). >> >> Otherwise looks good: >> >> Reviewed-by: Christoph Hellwig <hch@xxxxxx> >> > -- Jani Nikula, Intel Open Source Graphics Center
