Re: [PATCH 1/2] dma-buf/sync-file: fix logic error in new fence merge code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I finally managed to find a machine and tested this series. If it is not too late

The series is Tested-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>

On 3/29/2022 9:00 AM, Christian König wrote:
When the array is empty because everything is signaled we can't use
add_fence() to add something because that would filter the signaled
fence again.

Signed-off-by: Christian König <christian.koenig@xxxxxxx>
Fixes: 519f490db07e ("dma-buf/sync-file: fix warning about fence containers")
---
  drivers/dma-buf/sync_file.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c
index b8dea4ec123b..514d213261df 100644
--- a/drivers/dma-buf/sync_file.c
+++ b/drivers/dma-buf/sync_file.c
@@ -262,7 +262,7 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a,
  	}
if (index == 0)
-		add_fence(fences, &index, dma_fence_get_stub());
+		fences[index++] = dma_fence_get_stub();
if (num_fences > index) {
  		struct dma_fence **tmp;



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux