Dear Christian,
Am 23.03.22 um 08:42 schrieb Christian König:
Am 23.03.22 um 07:42 schrieb Paul Menzel:
Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam:
- Remove drm_mm references and replace with drm buddy functionalities
The commit message summary to me suggested, you can somehow use both
allocators now. Two suggestions below:
1. Switch to drm buddy allocator
2. Use drm buddy alllocator
- Add res cursor support for drm buddy
As an allocator switch sounds invasive, could you please extend the
commit message, briefly describing the current situation, saying what
the downsides are, and why the buddy allocator is “better”.
Well, Paul please stop bothering developers with those requests.
It's my job as maintainer to supervise the commit messages and it is
certainly NOT require to explain all the details of the current
situation in a commit message. That is just overkill.
I did not request all the details, and I think my requests are totally
reasonable. But let’s change the perspective. If there were not any AMD
graphics drivers bug, I would have never needed to look at the code and
deal with it. Unfortunately the AMD graphics driver situation – which
improved a lot in recent years – with no public documentation,
proprietary firmware and complex devices is still not optimal, and a lot
of bugs get reported, and I am also hit by bugs, taking time to deal
with them, and maybe reporting and helping to analyze them. So to keep
your wording, if you would stop bothering users with bugs and requesting
their help in fixing them – asking the user to bisect the issue is often
the first thing. Actually it should not be unreasonable for customers
buying an AMD device to expect get bug free drivers. It’s strange and a
sad fact, that the software industry succeeded to sway that valid
expectation and customers now except they need to regularly install
software updates, and do not get, for example, a price reduction when
there are bugs.
Also, as stated everywhere, reviewer time is scarce, so commit authors
should make it easy to attract new folks.
A simple note that we are switching from the drm_mm backend to the buddy
backend is sufficient, and that is exactly what the commit message is
saying here.
Sorry, I disagree. The motivation needs to be part of the commit
message. For example see recent discussion on the LWN article
*Donenfeld: Random number generator enhancements for Linux 5.17 and
5.18* [1].
How much the commit message should be extended, I do not know, but the
current state is insufficient (too terse).
Kind regards,
Paul
[1]: https://lwn.net/Articles/888413/
"Donenfeld: Random number generator enhancements for Linux 5.17
and 5.18"
