On Mon, 2022-03-21 at 14:58 +0100, Christian König wrote: > ⚠ External Email: This email originated from outside of the > organization. Do not click links or open attachments unless you > recognize the sender. > > Instead use the new dma_resv_get_singleton function. > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > Cc: VMware Graphics <linux-graphics-maintainer@xxxxxxxxxx> > Cc: Zack Rusin <zackr@xxxxxxxxxx> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c > index 708899ba2102..36c3b5db7e69 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c > @@ -1165,8 +1165,10 @@ int vmw_resources_clean(struct > vmw_buffer_object *vbo, pgoff_t start, > vmw_bo_fence_single(bo, NULL); > if (bo->moving) > dma_fence_put(bo->moving); > - bo->moving = dma_fence_get > - (dma_resv_excl_fence(bo->base.resv)); > + > + /* TODO: This is actually a memory management > dependency */ > + return dma_resv_get_singleton(bo->base.resv, false, > + &bo->moving); > } > > return 0; > -- > 2.25.1 > Sorry, I haven't had the time to go over the entire series, the patch looks good, but what's the memory management dependency the todo mentions? z
