Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Patrik-Jakobsson/drm-gma500-Remove-unused-declarations-and-other-cruft/20220317-172741 base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220318/202203180409.kj2q4cgM-lkp@xxxxxxxxx/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/0d50efabcb4ad52bd7a036e2542dbf51bbcf93b4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Patrik-Jakobsson/drm-gma500-Remove-unused-declarations-and-other-cruft/20220317-172741 git checkout 0d50efabcb4ad52bd7a036e2542dbf51bbcf93b4 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/gma500/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/gpu/drm/gma500/psb_drv.c:102:6: warning: no previous prototype for 'psb_spank' [-Wmissing-prototypes] 102 | void psb_spank(struct drm_psb_private *dev_priv) | ^~~~~~~~~ vim +/psb_spank +102 drivers/gpu/drm/gma500/psb_drv.c 5c49fd3aa0ab02 Alan Cox 2011-11-03 95 5c209d8056b976 Patrik Jakobsson 2021-02-01 96 /** 5c209d8056b976 Patrik Jakobsson 2021-02-01 97 * psb_spank - reset the 2D engine 5c209d8056b976 Patrik Jakobsson 2021-02-01 98 * @dev_priv: our PSB DRM device 5c209d8056b976 Patrik Jakobsson 2021-02-01 99 * 5c209d8056b976 Patrik Jakobsson 2021-02-01 100 * Soft reset the graphics engine and then reload the necessary registers. 5c209d8056b976 Patrik Jakobsson 2021-02-01 101 */ 5c209d8056b976 Patrik Jakobsson 2021-02-01 @102 void psb_spank(struct drm_psb_private *dev_priv) 5c209d8056b976 Patrik Jakobsson 2021-02-01 103 { 5c209d8056b976 Patrik Jakobsson 2021-02-01 104 PSB_WSGX32(_PSB_CS_RESET_BIF_RESET | _PSB_CS_RESET_DPM_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 105 _PSB_CS_RESET_TA_RESET | _PSB_CS_RESET_USE_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 106 _PSB_CS_RESET_ISP_RESET | _PSB_CS_RESET_TSP_RESET | 5c209d8056b976 Patrik Jakobsson 2021-02-01 107 _PSB_CS_RESET_TWOD_RESET, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 108 PSB_RSGX32(PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 109 5c209d8056b976 Patrik Jakobsson 2021-02-01 110 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 111 5c209d8056b976 Patrik Jakobsson 2021-02-01 112 PSB_WSGX32(0, PSB_CR_SOFT_RESET); 5c209d8056b976 Patrik Jakobsson 2021-02-01 113 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 114 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) | _PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 115 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 116 wmb(); 5c209d8056b976 Patrik Jakobsson 2021-02-01 117 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 118 5c209d8056b976 Patrik Jakobsson 2021-02-01 119 msleep(1); 5c209d8056b976 Patrik Jakobsson 2021-02-01 120 PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) & ~_PSB_CB_CTRL_CLEAR_FAULT, 5c209d8056b976 Patrik Jakobsson 2021-02-01 121 PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 122 (void) PSB_RSGX32(PSB_CR_BIF_CTRL); 5c209d8056b976 Patrik Jakobsson 2021-02-01 123 PSB_WSGX32(dev_priv->gtt.gatt_start, PSB_CR_BIF_TWOD_REQ_BASE); 5c209d8056b976 Patrik Jakobsson 2021-02-01 124 } 5c209d8056b976 Patrik Jakobsson 2021-02-01 125 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
