> Subject: Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with > drm_bridge_connector > Date: Wed, 23 Feb 2022 16:40:56 -0800 > From: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> > To: Stephen Boyd <swboyd@xxxxxxxxxxxx>, Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> > CC: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>, Bjorn Andersson > <bjorn.andersson@xxxxxxxxxx>, Rob Clark <robdclark@xxxxxxxxx>, Sean Paul > <sean@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter > <daniel@xxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, dri- > devel@xxxxxxxxxxxxxxxxxxxxx, freedreno@xxxxxxxxxxxxxxxxxxxxx > > > On 2/23/2022 1:33 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-02-23 10:27:26) > >> On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: > >>> On 23/02/2022 20:21, Kuogee Hsieh wrote: > >>> > >>> In the panel device node. > >>> > >>> Can you please share it too? > >> > >> &soc { > >> edp_power_supply: edp_power { > >> compatible = "regulator-fixed"; > >> regulator-name = "edp_backlight_power"; > >> > >> regulator-always-on; > >> regulator-boot-on; > >> }; > >> > >> edp_backlight: edp_backlight { > >> compatible = "pwm-backlight"; > >> > >> pwms = <&pm8350c_pwm 3 65535>; > >> power-supply = <&edp_power_supply>; > >> enable-gpio = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>; > >> > >> pinctrl-names = "default"; > >> pinctrl-0 = <&backlight_pwm_default>; > >> }; > >> > >> edp_panel: edp_panel { > >> compatible = "sharp_lq140m1jw46"; > > Is that supposed to be sharp,lq140m1jw46 with a comma instead of an > > underscore? > > Stephen, > > This is our internal branch which does not have patches up to date yet. > > I will cherry-pick newer edp related patches which are under review now to > re test it. Tested-by: Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx> Detect returned eDP not connected because the panel power was not on and mode_valid was failing because the DP mode_valid is different from eDP