On 3/15/22 02:26, Alyssa Rosenzweig wrote: > On Tue, Mar 15, 2022 at 01:42:53AM +0300, Dmitry Osipenko wrote: >> Replace Panfrost's memory shrinker with a generic DRM memory shrinker. >> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/panfrost/Makefile | 1 - >> drivers/gpu/drm/panfrost/panfrost_device.h | 4 ---- >> drivers/gpu/drm/panfrost/panfrost_drv.c | 19 ++------------- >> drivers/gpu/drm/panfrost/panfrost_gem.c | 27 ++++++++++++++-------- >> drivers/gpu/drm/panfrost/panfrost_gem.h | 9 -------- >> drivers/gpu/drm/panfrost/panfrost_job.c | 22 +++++++++++++++++- >> 6 files changed, 40 insertions(+), 42 deletions(-) >> >> diff --git a/drivers/gpu/drm/panfrost/Makefile b/drivers/gpu/drm/panfrost/Makefile >> index b71935862417..ecf0864cb515 100644 >> --- a/drivers/gpu/drm/panfrost/Makefile >> +++ b/drivers/gpu/drm/panfrost/Makefile >> @@ -5,7 +5,6 @@ panfrost-y := \ >> panfrost_device.o \ >> panfrost_devfreq.o \ >> panfrost_gem.o \ >> - panfrost_gem_shrinker.o \ >> panfrost_gpu.o \ >> panfrost_job.o \ >> panfrost_mmu.o \ > > I'm not sure you actually deleted gem_shrinker anywhere in this patch? > Diff stat is too small. Indeed, I was also confused by the diffstat once noticed it after the patches were sent out. And yes, I missed to git-add the panfrost_gem_shrinker.c by accident. Good catch, thank you! I'll correct it in in the v3. Meanwhile, will be great if you or somebody else could test this Panfrost patch. I don't have any h/w with Mali on hands yet and only compile-tested it.
