Re: [RESEND v13 07/22] soc: mediatek: mmsys: specify 64BIT dependency for MTK_MMSYS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Angelo,

Thanks for the review.

On Tue, 2022-03-08 at 14:41 +0100, AngeloGioacchino Del Regno wrote:
> Il 08/03/22 10:30, Nancy.Lin ha scritto:
> > Because mtk-mutex change to use unsigned long mutex module type,
> > it should depend 64BIT. This is a preparation for adding support
> > for
> > mt8195 vdosys1 mutex.
> > 
> > Signed-off-by: Nancy.Lin <nancy.lin@xxxxxxxxxxxx>
> > ---
> >   drivers/soc/mediatek/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/soc/mediatek/Kconfig
> > b/drivers/soc/mediatek/Kconfig
> > index fdd8bc08569e..24f792c46444 100644
> > --- a/drivers/soc/mediatek/Kconfig
> > +++ b/drivers/soc/mediatek/Kconfig
> > @@ -68,6 +68,7 @@ config MTK_SCPSYS_PM_DOMAINS
> >   config MTK_MMSYS
> >   	bool "MediaTek MMSYS Support"
> >   	default ARCH_MEDIATEK
> > +	depends on 64BIT
> >   	depends on HAS_IOMEM
> >   	help
> >   	  Say yes here to add support for the MediaTek Multimedia
> 
> Breaking old platforms is forbidden.
> 
> MT2701 and MT7623N are 32-bit ARM SoCs and:
> - mt2701 needs mmsys only; but
> - mt7623n needs mmsys and mutex.
> 
> Besides, this is an easy fix: just change your unsigned long to a
> fixed size u64.

OK, I will change to use fixed size u64. Thanks for your sugguestion.

Regards,
Nancy




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux