On Thu, 10 Mar 2022 at 08:16, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > > On Wed, Mar 9, 2022 at 5:12 PM Dave Airlie <airlied@xxxxxxxxx> wrote: > > > > On Tue, 8 Mar 2022 at 06:08, Alex Deucher <alexander.deucher@xxxxxxx> wrote: > > > > > > Hi Dave, Daniel, > > > > > > Same PR as last week, just fixed up a bad Fixes tag. > > > > > > The following changes since commit 38a15ad9488e21cad8f42d3befca20f91e5b2874: > > > > > > Merge tag 'amd-drm-next-5.18-2022-02-25' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-03-01 16:19:02 +1000) > > > > > > are available in the Git repository at: > > > > > > https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.18-2022-03-07 > > > > > > for you to fetch changes up to 53b97af4a44abd21344cc9f13986ba53051287bb: > > > > > > drm/amdkfd: Add format attribute to kfd_smi_event_add (2022-03-07 14:59:59 -0500) > > > > clang says no. > > > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:508:6: > > error: variable 'vmid' is used uninitialized whenever 'if' condition > > is false [-Werror,-Wsometimes-uninitialized] > > if (dev->kfd2kgd->get_atc_vmid_pasid_mapping_info) { > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:521:6: > > note: uninitialized use occurs here > > if (vmid > last_vmid_to_scan) { > > ^~~~ > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:508:2: > > note: remove the 'if' if its condition is always true > > if (dev->kfd2kgd->get_atc_vmid_pasid_mapping_info) { > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device_queue_manager.c:490:19: > > note: initialize the variable 'vmid' to silence this warning > > unsigned int vmid; > > ^ > > = 0 > > > > Already fixed in: > https://gitlab.freedesktop.org/agd5f/linux/-/commit/455331caeea5058d6df20f31a414b68ca502ec25 > was going to send that out with additional fixes this week, but I can > just spin a new PR if you'd prefer. A respin would be great, Thanks, Dave.
