Hi, On Thu, Mar 3, 2022 at 3:02 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Tue, Mar 1, 2022 at 6:11 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > > > > DP AUX transactions can consist of many short operations. There's no > > need to power things up/down in short intervals. > > > > I pick an arbitrary 100ms; for the systems I'm testing (Rockchip > > RK3399), runtime-PM transitions only take a few microseconds. > > > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > --- > > > > Changes in v4: > > - call pm_runtime_mark_last_busy() and > > pm_runtime_dont_use_autosuspend() > > - drop excess pm references around drm_get_edid(), now that we grab and > > hold in the dp-aux helper > > > > Changes in v3: > > - New in v3 > > > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > This looks great to me now, thanks. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Though I'm not a massive expert on the Analogix DP driver, I'm pretty > confident about the DP AUX stuff that Brian is touching. I just > checked and I see that this driver isn't changing lots and the last > change landed in drm-misc, which means that I can commit this. Thus, > unless someone else shouts, I'll plan to wait until next week and > commit these two patches to drm-misc. > > The first of the two patches is a "Fix" but since it's been broken > since 2016 I'll assume that nobody is chomping at the bit for these to > get into stable and that it would be easier to land both in > "drm-misc-next". Please yell if someone disagrees. Pushed both to drm-misc-next: f28dd5075675 drm/bridge: analogix_dp: Enable autosuspend 8fb6c44fe846 drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX -Doug
