Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indenting

[Christian König <christian.koenig@xxxxxxx>]

Am 03.03.22 um 02:52 schrieb Yang Li:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
> warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 91817a31f3e1..4ff6e06babca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
>   	 */
>   	if (adev->reset_domain->type != XGMI_HIVE) {
>   		hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
> -			if (!hive->reset_domain) {
> -				dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> -				ret = -ENOMEM;
> -				kobject_put(&hive->kobj);
> -				kfree(hive);
> -				hive = NULL;
> -				goto pro_end;
> -			}
> +		if (!hive->reset_domain) {
> +			dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> +			ret = -ENOMEM;
> +			kobject_put(&hive->kobj);
> +			kfree(hive);
> +			hive = NULL;
> +			goto pro_end;
> +		}
>   	} else {
>   		amdgpu_reset_get_reset_domain(adev->reset_domain);
>   		hive->reset_domain = adev->reset_domain;