On Mon, Feb 21, 2022 at 10:59:15AM +0100, Maxime Ripard wrote:
> The komeda KMS driver will call drm_plane_create_color_properties() with
> a default encoding and range values of BT601 and Limited Range,
> respectively.
>
> Since the initial value wasn't carried over in the state, the driver had
> to set it again in komeda_plane_reset(). However, the helpers have been
> adjusted to set it properly at reset, so this is not needed anymore.
>
> Cc: Brian Starkey <brian.starkey@xxxxxxx>
> Cc: "James (Qian) Wang" <james.qian.wang@xxxxxxx>
> Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> Cc: Mihail Atanassov <mihail.atanassov@xxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
Acked-by: Liviu Dudau <liviu.dudau@xxxxxxx>
Neat splitting of changes even if the removed lines were consecutive, thanks!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index 383bb2039bd4..541949f2d44a 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -143,11 +143,8 @@ static void komeda_plane_reset(struct drm_plane *plane)
> plane->state = NULL;
>
> state = kzalloc(sizeof(*state), GFP_KERNEL);
> - if (state) {
> + if (state)
> __drm_atomic_helper_plane_reset(plane, &state->base);
> - state->base.color_encoding = DRM_COLOR_YCBCR_BT601;
> - state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;
> - }
> }
>
> static struct drm_plane_state *
> --
> 2.35.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
