On Mon, Feb 21, 2022 at 10:59:05AM +0100, Maxime Ripard wrote:
> The komeda KMS driver will call drm_plane_create_zpos_property() with an
> init value of the plane index.
>
> Since the initial value wasn't carried over in the state, the driver had
> to set it again in komeda_plane_reset(). However, the helpers have been
> adjusted to set it properly at reset, so this is not needed anymore.
>
> Cc: Brian Starkey <brian.starkey@xxxxxxx>
> Cc: "James (Qian) Wang" <james.qian.wang@xxxxxxx>
> Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> Cc: Mihail Atanassov <mihail.atanassov@xxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
Acked-by: Liviu Dudau <liviu.dudau@xxxxxxx>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index 1778f6e1ea56..383bb2039bd4 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -135,7 +135,6 @@ static void komeda_plane_destroy(struct drm_plane *plane)
> static void komeda_plane_reset(struct drm_plane *plane)
> {
> struct komeda_plane_state *state;
> - struct komeda_plane *kplane = to_kplane(plane);
>
> if (plane->state)
> __drm_atomic_helper_plane_destroy_state(plane->state);
> @@ -146,7 +145,6 @@ static void komeda_plane_reset(struct drm_plane *plane)
> state = kzalloc(sizeof(*state), GFP_KERNEL);
> if (state) {
> __drm_atomic_helper_plane_reset(plane, &state->base);
> - state->base.zpos = kplane->layer->base.id;
> state->base.color_encoding = DRM_COLOR_YCBCR_BT601;
> state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;
> }
> --
> 2.35.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
