Op 23-02-2022 om 16:11 schreef Christian König: > Am 23.02.22 um 14:51 schrieb Maarten Lankhorst: >> Second version of the patch. I didn't fix the copyright (which ame up >> in the previous version), as I feel the original author should send a >> patch for that. >> >> I've made the suballocator into its own module, and did a cleanup pass on it. >> The suballocator is generic enough to be useful for any resource that can be >> subdivided and is guarded by a completion fence. > > Well the main issue is still that you removed the per allocation alignment. > > For amdgpu that is not much of a problem, but for radeon that could cause massive issues with UVD semaphore synchronization. Hey, Is this really a problem? I made the per allocation alignment fixed and set it to the higher of the 2 places it's used in by radeon. This just means that slightly more memory might be allocated to each suballocation. This shouldn't cause any problem. It would reserve 256 bytes for a semaphore allocation, instead of 8. ~Maarten
