On Thu, Feb 24, 2022 at 05:36:29PM +0300, Dmitry Osipenko wrote: > On 2/24/22 10:47, Sascha Hauer wrote: > > On Thu, Feb 17, 2022 at 04:24:29PM +0300, Dmitry Osipenko wrote: > >> 17.02.2022 11:29, Sascha Hauer пишет: > >>> @@ -28,6 +28,12 @@ config ROCKCHIP_VOP > >>> This selects support for the VOP driver. You should enable it > >>> on all older SoCs up to RK3399. > >>> > >>> +config ROCKCHIP_VOP2 > >>> + bool "Rockchip VOP2 driver" > >>> + help > >>> + This selects support for the VOP2 driver. You should enable it > >>> + on all newer SoCs beginning form RK3568. > >> > >> s/form/from/ > >> > >> The ROCKCHIP_VOP option is "default y". Do you really want "default n" > >> for the VOP2? > > > > ROCKCHIP_VOP is only default y to keep the VOP driver enabled for > > existing defconfig that were generated before the introduction of > > that symbol. > > We don't have this problem for VOP2, so no need to make it default y. > > To me it will be more consistent of you'll have both defaulting to y, > since both options are behind DRM_ROCKCHIP. New drivers should not be enabled by default, at least that's what I have been told before. The VOP driver is enabled by default for the reasons explained. But yes, you are right, it's more consistent to have the same default on both drivers. Personally I don't care much, for now I just follow what Heiko suggests as he is the one who hopefully merges these patches ;) Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
