On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote:
> On 2/23/22 17:45, Michal Suchánek wrote:
>
> [snip]
>
> >>>
> >>> To enable use of VESA modes with simplefb in legacy BIOS boot mode drop
> >>
> >> I think you meant "VESA modes with the sysfb driver" ? or something like
> >> that since otherwise it seems that you meant to use it with the simplefb
> >> (drivers/video/fbdev/simplefb.c) fbdev driver, which doesn't support the
> >> "vga=" param as far as I understand (it just uses whatever was setup).
> >
> > And the vga= is whatever was set up by the realmode code. And the config
> > option for realmode code to do that is selected by vesafb and not
> > simplefb so it does not wotk for simplefb/simpledrm/whatewer when efifib
> > is not built into the kernel.
> >
>
> Yes, that's what I tried to say. But your commit message says "To enable
> use of VESA modes with simplefb in legacy BIOS boot mode" and that isn't
> accurate AFAIU (unless you meant sysfb instead).
config SYSFB_SIMPLEFB
bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
depends on SYSFB
+ select BOOT_VESA_SUPPORT if X86
This to me means that it's simplefb specifically that requires it, not sysfb.
More precisely SYSFB_SIMPLEFB which is the simplefb implementation on top of
legacy BIOS.
Thanks
Michal
