Hello Hans, On 2/21/22 23:00, Hans de Goede wrote: > Some devices use e.g. a portrait panel in a standard laptop casing made > for landscape panels. efifb calls drm_get_panel_orientation_quirk() and > sets fb_info.fbcon_rotate_hint to make fbcon rotate the console so that > it shows up-right instead of on its side. > > When switching to simpledrm to fbcon renders on its side. Call the This sentence sounds a little off to me. Did you mean: "the fbcon renders on its side." ? Maybe you can say something like the following: When switching to simpledrm, fbcon attachs to the fbdev emulated by the DRM core instead. And the fb_info.fbcon_rotate_hint field is set by the emulation layer, if panel orientation was set for a connector. > drm_connector_set_panel_orientation_with_quirk() helper to add > a "panel orientation" property on devices listed in the quirk table, > to make the fbcon (and aware userspace apps) rotate the image to > display properly. > > Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- The patch looks good to me. Thanks a lot for fixing this Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
